Bladeren bron

Remove event listener when component is destroyed, n.b. this removes throttling

sbkwgh 8 jaren geleden
bovenliggende
commit
f502bd0b57
2 gewijzigde bestanden met toevoegingen van 8 en 9 verwijderingen
  1. 4 5
      src/components/widgets/CategoriesChart.vue
  2. 4 4
      src/components/widgets/LineChart.vue

+ 4 - 5
src/components/widgets/CategoriesChart.vue

@@ -134,15 +134,14 @@
 		},
 		mounted () {
 			this.updateFuncs()
-
-			let resizeCb = throttle(() => {
-				this.updateFuncs()
-			}, 200)
-			window.addEventListener('resize', resizeCb)
+			window.addEventListener('resize', this.updateFuncs)
 
 			setTimeout(() => {
 				this.loading = false;
 			}, Math.random()*3000)
+		},
+		destroyed () {
+			window.removeEventListener('resize', this.updateFuncs)
 		}
 	}
 </script>

+ 4 - 4
src/components/widgets/LineChart.vue

@@ -142,14 +142,14 @@
 		mounted () {
 			this.updateFuncs()
 
-			let resizeCb = throttle(() => {
-				this.updateFuncs()
-			}, 200)
-			window.addEventListener('resize', resizeCb)
+			window.addEventListener('resize', this.updateFuncs)
 
 			setTimeout(() => {
 				this.loading = false;
 			}, Math.random()*3000)
+		},
+		destroyed () {
+			window.removeEventListener('resize', this.updateFuncs)
 		}
 	}
 </script>